Skip to content

MQE-1711: Switch between Developer mode and Production mode takes lon… #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 26, 2019

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Nov 21, 2019

…g time and the test end up time out.

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

…g time and the test end up time out

fixed static checks + unit tests, added documentation.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 52.943% when pulling fceb17f on MQE-1711 into 26ef6b0 on develop.

@coveralls
Copy link

coveralls commented Nov 22, 2019

Coverage Status

Coverage increased (+0.3%) to 52.161% when pulling f6a7763 on MQE-1711 into 4bbcab4 on develop.

…g time and the test end up time out

fixed issue with signature of magentoCLI
…g time and the test end up time out

fixed issue with signature of magentoCLI
Copy link
Contributor

@tomreece tomreece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds look good:
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/27013/

Minor changes requested around documentation and a verification test.

…g time and the test end up time out

Added verification test for magentoCLISecret.
Copy link
Contributor Author

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed review comments.

Copy link
Contributor

@tomreece tomreece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@soumyau soumyau merged commit 16d6880 into develop Nov 26, 2019
@soumyau soumyau deleted the MQE-1711 branch April 30, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants